Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IGNITE-24029 Sql schema. Extend Table API with supporting qualified names #5038

Merged
merged 11 commits into from
Jan 24, 2025

Conversation

AMashenkov
Copy link
Member

Thank you for submitting the pull request.

To streamline the review process of the patch and ensure better code quality
we ask both an author and a reviewer to verify the following:

The Review Checklist

  • Formal criteria: TC status, codestyle, mandatory documentation. Also make sure to complete the following:
    - There is a single JIRA ticket related to the pull request.
    - The web-link to the pull request is attached to the JIRA ticket.
    - The JIRA ticket has the Patch Available state.
    - The description of the JIRA ticket explains WHAT was made, WHY and HOW.
    - The pull request title is treated as the final commit message. The following pattern must be used: IGNITE-XXXX Change summary where XXXX - number of JIRA issue.
  • Design: new code conforms with the design principles of the components it is added to.
  • Patch quality: patch cannot be split into smaller pieces, its size must be reasonable.
  • Code quality: code is clean and readable, necessary developer documentation is added if needed.
  • Tests code quality: test set covers positive/negative scenarios, happy/edge cases. Tests are effective in terms of execution time and resources.

Notes

@AMashenkov AMashenkov force-pushed the ignite-24029 branch 13 times, most recently from 8a5b0a5 to 12199b2 Compare January 20, 2025 13:52
@ptupitsyn ptupitsyn self-requested a review January 20, 2025 14:03
@AMashenkov AMashenkov force-pushed the ignite-24029 branch 4 times, most recently from 89fd016 to 8bb2115 Compare January 20, 2025 22:41
@AMashenkov AMashenkov requested a review from isapego January 21, 2025 08:29
Copy link
Contributor

@ptupitsyn ptupitsyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Public API changes and .NET changes look good to me.

@AMashenkov AMashenkov force-pushed the ignite-24029 branch 2 times, most recently from 5c1be1e to 3de97f3 Compare January 21, 2025 16:15
@AMashenkov AMashenkov merged commit f843e2a into main Jan 24, 2025
1 check passed
@AMashenkov AMashenkov deleted the ignite-24029 branch January 24, 2025 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants